diff options
| author | Martin Schwidefsky <schwidefsky@de.ibm.com> | 2007-02-21 09:55:00 (GMT) |
|---|---|---|
| committer | Martin Schwidefsky <schwidefsky@de.ibm.com> | 2007-02-21 09:55:00 (GMT) |
| commit | bf6f6aa46feada857a52cb67d99a7c2fe4a70e87 (patch) | |
| tree | 930dbd9bcd693cd7f3487fe8072bb0548131ff51 /arch/s390/lib | |
| parent | 489c80ba8aa9dde8244897cba33a9372c897e531 (diff) | |
| download | linux-fsl-qoriq-bf6f6aa46feada857a52cb67d99a7c2fe4a70e87.tar.xz | |
[S390] prevent softirqs if delay is called disabled
The new delay implementation uses the clock comparator and an external
interrupt even if it is called disabled for interrupts. To do this
all external interrupt source except clock comparator are switched of
before enabling external interrupts. The external interrupt at the
end of the delay period may not execute softirqs or we can end up in a
dead-lock.
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
Diffstat (limited to 'arch/s390/lib')
| -rw-r--r-- | arch/s390/lib/delay.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/arch/s390/lib/delay.c b/arch/s390/lib/delay.c index 0285444..70f2a86 100644 --- a/arch/s390/lib/delay.c +++ b/arch/s390/lib/delay.c @@ -15,6 +15,7 @@ #include <linux/delay.h> #include <linux/timex.h> #include <linux/irqflags.h> +#include <linux/interrupt.h> void __delay(unsigned long loops) { @@ -35,7 +36,11 @@ void __udelay(unsigned long usecs) { u64 end, time, jiffy_timer = 0; unsigned long flags, cr0, mask, dummy; + int irq_context; + irq_context = in_interrupt(); + if (!irq_context) + local_bh_disable(); local_irq_save(flags); if (raw_irqs_disabled_flags(flags)) { jiffy_timer = S390_lowcore.jiffy_timer; @@ -62,6 +67,8 @@ void __udelay(unsigned long usecs) __ctl_load(cr0, 0, 0); S390_lowcore.jiffy_timer = jiffy_timer; } + if (!irq_context) + _local_bh_enable(); set_clock_comparator(S390_lowcore.jiffy_timer); local_irq_restore(flags); } |