diff options
author | Julia Lawall <julia@diku.dk> | 2010-03-30 05:33:28 (GMT) |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-03-30 05:33:28 (GMT) |
commit | c4a3987fa075b2d15ebc3d59b01fb7ed403cd3e1 (patch) | |
tree | b751350fb5c0abc2c8f636dae7429d409300be7f /arch/sparc | |
parent | 9e8307ecaf9f8c8b5b3b22145021204c4e73114a (diff) | |
download | linux-fsl-qoriq-c4a3987fa075b2d15ebc3d59b01fb7ed403cd3e1.tar.xz |
drivers/serial/sunsu.c: Correct use after free
The of_iounmap is at the out_unmap label, but at that point up has already
been freed. The free cannot be moved to the out_unmap label, because that
label is reachable from cases where up should not be freed. So the call to
of_iounmap is just duplicated, and the goto converted to a return.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@@
expression x,e;
identifier f;
iterator I;
statement S;
@@
*kfree(x);
... when != &x
when != x = e
when != I(x,...) S
*x->f
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'arch/sparc')
0 files changed, 0 insertions, 0 deletions