diff options
author | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-03-07 03:38:01 (GMT) |
---|---|---|
committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-03-07 03:38:01 (GMT) |
commit | 38f3323037de22bb0089d08be27be01196e7148b (patch) | |
tree | a4614cbaf4880b3f782b74df91bbfcac8c3308f2 /drivers/char/mem.c | |
parent | 5d6deb940f880140fbcf5ec42e92534e78785e99 (diff) | |
download | linux-fsl-qoriq-38f3323037de22bb0089d08be27be01196e7148b.tar.xz |
Revert "[PATCH] LOG2: Alter get_order() so that it can make use of ilog2() on a constant"
This reverts commit 39d61db0edb34d60b83c5e0d62d0e906578cc707.
The commit was buggy in multiple ways:
- the conversion to ilog2() was incorrect to begin with
- it tested the wrong #defines, so on all architectures but FRV you'd
never see the bug except for constant arguments.
- the new "get_order()" macro used its arguments multiple times, and
didn't even parenthesize them properly
- despite the comments, it was not true that you could use it for
constant initializers, since not all architectures even use the
generic page.h header file.
All of the problems are individually fixable, but it all boils down to:
better just revert it, and re-do it from scratch.
Cc: David Howells <dhowells@redhat.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/char/mem.c')
0 files changed, 0 insertions, 0 deletions