diff options
author | Don Morris <don.morris@hp.com> | 2012-03-15 18:07:30 (GMT) |
---|---|---|
committer | Dan Williams <dan.j.williams@intel.com> | 2012-03-28 08:47:49 (GMT) |
commit | 3d9ea9e3af048ab6b8dced15248384e548ba05ea (patch) | |
tree | 3c2d2de74755dc9d2b4d2955f88a0a3cb96ea02b /drivers/dma/ioat/dma_v2.h | |
parent | 275029353953c2117941ade84f02a2303912fad1 (diff) | |
download | linux-fsl-qoriq-3d9ea9e3af048ab6b8dced15248384e548ba05ea.tar.xz |
iop-adma: Corrected array overflow in RAID6 Xscale(R) test.
Bug: cppcheck reported overflow in array assignment (for loop walks
0 to IOP_ADMA_NUM_SRC_TEST+2, array size is IOP_ADMA_NUM_SRC_TEST).
Reported as: https://bugzilla.kernel.org/show_bug.cgi?id=42677
Test code pq_src array was grown by two elements to correspond with actual
usage (IOP_ADMA_NUM_SRC_TEST+2), stack consumption was kept constant by
modifying the pq_dest two element array which is only used when pq_src
is referenced up to IOP_ADMA_NUM_SRC_TEST elements into the address
of the new last two elements of the pq_src array. This is presumed to
be the original intent but would be reliant on compilers always having
pq_dest contiguous with the final element of pq_src.
Note: This is a re-send of a request for review from two weeks ago.
Looking for review (or shootdown), adding LKML to list for a wider
audience. Thanks.
Updated per review comments of Sergei Shtylyov <sshtylyov@mvista.com>
Signed-off-by: Don Morris <don.morris@hp.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Diffstat (limited to 'drivers/dma/ioat/dma_v2.h')
0 files changed, 0 insertions, 0 deletions