summaryrefslogtreecommitdiff
path: root/drivers/hwmon
diff options
context:
space:
mode:
authorGuenter Roeck <linux@roeck-us.net>2014-04-21 17:38:08 (GMT)
committerMatthew Weigel <Matthew.Weigel@freescale.com>2014-12-11 18:36:11 (GMT)
commitbd7702f31675f02e8554ab326eacc3b89ad2058a (patch)
tree79c81156f388a45fb20f5e2667889340a3816b4c /drivers/hwmon
parent23ad92f65643b08c6f473a4083b350ad7cc501c5 (diff)
downloadlinux-fsl-qoriq-bd7702f31675f02e8554ab326eacc3b89ad2058a.tar.xz
hwmon: (ltc2945) Don't crash the kernel unnecessarily
An implementation error should not crash the kernel if it is avoidable. Replace BUG() with WARN_ONCE(). Signed-off-by: Guenter Roeck <linux@roeck-us.net> (cherry picked from commit f75d72309192e52ef9a3efb390b1c4f408c142df) Change-Id: Ib1d20bb2f35fd6f5c551f137102dbd12c68aa489 Reviewed-on: http://git.am.freescale.net:8181/19635 Tested-by: Review Code-CDREVIEW <CDREVIEW@freescale.com> Reviewed-by: Zhengxiong Jin <Jason.Jin@freescale.com>
Diffstat (limited to 'drivers/hwmon')
-rw-r--r--drivers/hwmon/ltc2945.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/hwmon/ltc2945.c b/drivers/hwmon/ltc2945.c
index c104cc3..c9cddf5 100644
--- a/drivers/hwmon/ltc2945.c
+++ b/drivers/hwmon/ltc2945.c
@@ -1,4 +1,4 @@
-/*
+ /*
* Driver for Linear Technology LTC2945 I2C Power Monitor
*
* Copyright (c) 2014 Guenter Roeck
@@ -314,8 +314,8 @@ static ssize_t ltc2945_reset_history(struct device *dev,
reg = LTC2945_MAX_ADIN_H;
break;
default:
- BUG();
- break;
+ WARN_ONCE(1, "Bad register: 0x%x\n", reg);
+ return -EINVAL;
}
/* Reset maximum */
ret = regmap_bulk_write(regmap, reg, buf_max, num_regs);