summaryrefslogtreecommitdiff
path: root/drivers/input/mouse/psmouse-base.c
diff options
context:
space:
mode:
authorDaniel Kurtz <djkurtz@chromium.org>2013-02-13 21:53:07 (GMT)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2013-02-14 04:21:12 (GMT)
commit48064bdcd6d1c27ad0a35103eb8cee2d087940d9 (patch)
tree0c567d4046c03be803fcdeadec5426ce412ae617 /drivers/input/mouse/psmouse-base.c
parentd722260d233949ec531c684248a88cb163608851 (diff)
downloadlinux-fsl-qoriq-48064bdcd6d1c27ad0a35103eb8cee2d087940d9.tar.xz
Input: synaptics - fix 1->3 contact transition reporting
Investigating the following gesture highlighted two slight implementation errors with choosing which slots to report in which slot when multiple contacts are present: Action SGM AGM (MTB slot:Contact) 1. Touch contact 0 (0:0) 2. Touch contact 1 (0:0, 1:1) 3. Lift contact 0 (1:1) 4. Touch contacts 2,3 (0:2, 1:3) In step 4, slot 1 was not being cleared first, which means the same tracking ID was being used for reporting both the old contact 1 and the new contact 3. This could result in "drumroll", where the old contact 1 would appear to suddenly jump to new finger 3 position. Similarly, if contacts 2 & 3 are not detected at the same sample, step 4 is split into two: Action SGM AGM (MTB slot:contact) 1. Touch contact 0 (0:0) 2. Touch contact 1 (0:0, 1:1) 3. Lift contact 0 (1:1) 4. Touch contact 2 (0:2, 1:1) 5. Touch contact 3 (0:2, 1:3) In this case, there was also a bug. In step 4, when contact 1 moves from SGM to AGM and contact 2 is first reported in SGM, slot 0 was actually empty. So slot 0 can be used to report the new SGM (contact 0), immediately. Since it was empty, contact 2 in slot 0 will get a new tracking ID. Signed-off-by: Daniel Kurtz <djkurtz@chromium.org> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Diffstat (limited to 'drivers/input/mouse/psmouse-base.c')
0 files changed, 0 insertions, 0 deletions