summaryrefslogtreecommitdiff
path: root/drivers/isdn/gigaset/common.c
diff options
context:
space:
mode:
authorJiri Slaby <jslaby@suse.cz>2012-03-05 13:52:54 (GMT)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-03-08 20:51:13 (GMT)
commitfc258f89405f63b379324d1f8388ae4810297997 (patch)
tree7027aadb38d74ff01e24c759339e75b16e0515dd /drivers/isdn/gigaset/common.c
parent5dd5bc40f3b6e0ccdaad948dbadc94ad0906cb25 (diff)
downloadlinux-fsl-qoriq-fc258f89405f63b379324d1f8388ae4810297997.tar.xz
TTY: isdn/gigaset, do not set tty->driver_data to NULL
Close the window in open where driver_data is reset to NULL on each open. It could cause other processes to get invalid retval from the tty->ops operations because of the checks all over the code. With this change we may do other cleanups. Now, the only valid check for tty->driver_data != NULL is in close. This can happen only if open fails at gigaset_get_cs_by_tty or try_module_get. The rest of checks in various tty->ops->* are invalid as driver_data cannot be NULL there. The same holds for cs->open_count. So remove them. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Hansjoerg Lipp <hjlipp@web.de> Cc: Tilman Schmidt <tilman@imap.cc> Cc: gigaset307x-common@lists.sourceforge.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/isdn/gigaset/common.c')
0 files changed, 0 insertions, 0 deletions