summaryrefslogtreecommitdiff
path: root/drivers/leds/leds-blinkm.c
diff options
context:
space:
mode:
authorManfred Schlaegl <manfred.schlaegl@gmx.at>2013-08-13 11:17:05 (GMT)
committerBryan Wu <cooloney@gmail.com>2013-08-27 00:46:36 (GMT)
commitc945cbcf453cb72dc2287fc4f7b63314f173b313 (patch)
treedd65b5b53670ce33b476ad15a470e9240b032ab7 /drivers/leds/leds-blinkm.c
parent8a6acd648c1dfdc82f1bbcd15f7777962054c268 (diff)
downloadlinux-fsl-qoriq-c945cbcf453cb72dc2287fc4f7b63314f173b313.tar.xz
leds: trigger: ledtrig-backlight: Fix invalid memory access in fb_event notification callback
fb_notifier_callback is called on any event fired by fb_notifier_call_chain. Events may, or may not contain some data (fb_event.data). In case of FB_EVENT_BLANK fb_event.data contains a pointer to an integer holdingthe blank state. The Problem is, that in ledtrig-backlight.c - fb_notifier_callback the pointer to blank state is dereferenced BEFORE the event-type is checked. Obviously this leads to problems with other events than FB_EVENT_BLANK, where fb_event.data is undefined or NULL. It seems, that this problem existed ever since the driver was added. Like in drivers/video/backlight/backlight.c line 43 I would suggest to return immediately on events other than FB_EVENT_BLANK. Signed-off-by: Manfred Schlaegl <manfred.schlaegl@gmx.at> Signed-off-by: Bryan Wu <cooloney@gmail.com>
Diffstat (limited to 'drivers/leds/leds-blinkm.c')
0 files changed, 0 insertions, 0 deletions