summaryrefslogtreecommitdiff
path: root/drivers/misc/c2port
diff options
context:
space:
mode:
authorGlauber Costa <glommer@parallels.com>2012-07-06 09:09:07 (GMT)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-07-17 16:43:55 (GMT)
commite5bcac61472ca627241b394d439decd00bba3aea (patch)
tree0b95f76e13777099dcedaf7483e93d174b9f75f5 /drivers/misc/c2port
parent47610d98e884dd47fd874469a105797e1a9f5ed0 (diff)
downloadlinux-fsl-qoriq-e5bcac61472ca627241b394d439decd00bba3aea.tar.xz
sysfs: fail dentry revalidation after namespace change
When we change the namespace tag of a sysfs entry, the associated dentry is still kept around. readdir() will work correctly and not display the old entries, but open() will still succeed, so will reads and writes. This will no longer happen if sysfs is remounted, hinting that this is a cache-related problem. I am using the following sequence to demonstrate that: shell1: ip link add type veth unshare -nm shell2: ip link set veth1 <pid_of_shell_1> cat /sys/devices/virtual/net/veth1/ifindex Before that patch, this will succeed (fail to fail). After it, it will correctly return an error. Differently from a normal rename, which we handle fine, changing the object namespace will keep it's path intact. So this check seems necessary as well. [ v2: get type from parent, as suggested by Eric Biederman ] Signed-off-by: Glauber Costa <glommer@parallels.com> CC: Tejun Heo <tj@kernel.org> Reviewed-by: "Eric W. Biederman" <ebiederm@xmission.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/misc/c2port')
0 files changed, 0 insertions, 0 deletions