diff options
| author | Shaohui Xie <Shaohui.Xie@freescale.com> | 2013-12-02 00:33:01 (GMT) |
|---|---|---|
| committer | Emilian Medve <Emilian.Medve@freescale.com> | 2014-01-01 02:08:26 (GMT) |
| commit | 4488f9a4ba0e49583fea7f95703a00f3c6e5d714 (patch) | |
| tree | f831a2e53664332f321a87d03ba430ea2e85190e /drivers/net/ethernet/freescale/xgmac_mdio.c | |
| parent | c72da5b67196faa5957ba0b0bed109e6d04dab93 (diff) | |
| download | linux-fsl-qoriq-4488f9a4ba0e49583fea7f95703a00f3c6e5d714.tar.xz | |
Revert "net/mdio: Program the PHY register number before initiating a read"
commit 3e94c4d20610, which is patch "net/mdio: Program the PHY register
number before initiating a read", which writes a Clause 45 PHY register
outside Clause 45, impacts the access to a Clause 22 PHY, then during
ASF test, error info "mdio_bus ffe5fc000: MDIO read error" can be observed
which causes the ASF failed, so revert it.
Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
Change-Id: Ic3c27f625835d6ac1f22028749d7111b0c0f7a48
Reviewed-on: http://git.am.freescale.net:8181/6988
Tested-by: Review Code-CDREVIEW <CDREVIEW@freescale.com>
Reviewed-by: Tiefei Zang <roy.zang@freescale.com>
Reviewed-by: Shruti Kanetkar <Shruti@freescale.com>
Reviewed-by: Thomas Trefny <Tom.Trefny@freescale.com>
(cherry picked from commit 8f4f55f161d594908d669657aeea2d4a049056d3)
Reviewed-on: http://git.am.freescale.net:8181/7073
Reviewed-by: Emilian Medve <Emilian.Medve@freescale.com>
Tested-by: Emilian Medve <Emilian.Medve@freescale.com>
Diffstat (limited to 'drivers/net/ethernet/freescale/xgmac_mdio.c')
| -rw-r--r-- | drivers/net/ethernet/freescale/xgmac_mdio.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c index 7e21e6c..b555b5f 100644 --- a/drivers/net/ethernet/freescale/xgmac_mdio.c +++ b/drivers/net/ethernet/freescale/xgmac_mdio.c @@ -181,8 +181,6 @@ static int xgmac_mdio_read(struct mii_bus *bus, int phy_id, int regnum) return ret; } - out_be32(®s->mdio_addr, regnum); - /* Initiate the read */ out_be32(®s->mdio_ctl, mdio_ctl | MDIO_CTL_READ); |