diff options
| author | Thomas Meyer <thomas@m3y3r.de> | 2011-12-02 12:36:13 (GMT) |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-12-04 06:32:06 (GMT) |
| commit | c2e4e25afcc8ae1835a6100089f1f9fd3a362430 (patch) | |
| tree | 91220e94fa972df95b7bb0277d019fdb9f3cdbf6 /drivers/net/ethernet/sfc/selftest.c | |
| parent | ddf98e6d30a966dbd6e675c90e2caa5b9486e519 (diff) | |
| download | linux-fsl-qoriq-c2e4e25afcc8ae1835a6100089f1f9fd3a362430.tar.xz | |
sfc: Use kcalloc instead of kzalloc to allocate array
The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.
The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/sfc/selftest.c')
| -rw-r--r-- | drivers/net/ethernet/sfc/selftest.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/sfc/selftest.c b/drivers/net/ethernet/sfc/selftest.c index 822f6c2..52edd24 100644 --- a/drivers/net/ethernet/sfc/selftest.c +++ b/drivers/net/ethernet/sfc/selftest.c @@ -503,8 +503,8 @@ efx_test_loopback(struct efx_tx_queue *tx_queue, /* Determine how many packets to send */ state->packet_count = efx->txq_entries / 3; state->packet_count = min(1 << (i << 2), state->packet_count); - state->skbs = kzalloc(sizeof(state->skbs[0]) * - state->packet_count, GFP_KERNEL); + state->skbs = kcalloc(state->packet_count, + sizeof(state->skbs[0]), GFP_KERNEL); if (!state->skbs) return -ENOMEM; state->flush = false; |