diff options
| author | Thomas Meyer <thomas@m3y3r.de> | 2011-12-02 12:36:13 (GMT) |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-12-04 06:32:06 (GMT) |
| commit | c2e4e25afcc8ae1835a6100089f1f9fd3a362430 (patch) | |
| tree | 91220e94fa972df95b7bb0277d019fdb9f3cdbf6 /drivers/net/ethernet/sfc/tx.c | |
| parent | ddf98e6d30a966dbd6e675c90e2caa5b9486e519 (diff) | |
| download | linux-fsl-qoriq-c2e4e25afcc8ae1835a6100089f1f9fd3a362430.tar.xz | |
sfc: Use kcalloc instead of kzalloc to allocate array
The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.
The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107
Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/sfc/tx.c')
| -rw-r--r-- | drivers/net/ethernet/sfc/tx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/sfc/tx.c b/drivers/net/ethernet/sfc/tx.c index e0e00b3..72f0fbc 100644 --- a/drivers/net/ethernet/sfc/tx.c +++ b/drivers/net/ethernet/sfc/tx.c @@ -479,7 +479,7 @@ int efx_probe_tx_queue(struct efx_tx_queue *tx_queue) tx_queue->queue, efx->txq_entries, tx_queue->ptr_mask); /* Allocate software ring */ - tx_queue->buffer = kzalloc(entries * sizeof(*tx_queue->buffer), + tx_queue->buffer = kcalloc(entries, sizeof(*tx_queue->buffer), GFP_KERNEL); if (!tx_queue->buffer) return -ENOMEM; |