diff options
| author | Larry Finger <Larry.Finger@lwfinger.net> | 2008-12-10 05:35:41 (GMT) |
|---|---|---|
| committer | John W. Linville <linville@tuxdriver.com> | 2008-12-12 19:02:08 (GMT) |
| commit | d8004cb9267b15cd902eef01a75bb1ffa3995af8 (patch) | |
| tree | 20d548f9c29aa68d9ff531ac79e6a8d04fcae60e /drivers/net | |
| parent | c1db52b9d27ee6e15a7136e67e4a21dc916cd07f (diff) | |
| download | linux-fsl-qoriq-d8004cb9267b15cd902eef01a75bb1ffa3995af8.tar.xz | |
b43legacy: Fix sparse warnings
Sparse yields the following warnings for b43legacy:
CHECK drivers/net/wireless/b43legacy/phy.c
drivers/net/wireless/b43legacy/phy.c:1304:31: warning: potentially expensive pointer subtraction
drivers/net/wireless/b43legacy/phy.c:1304:31: warning: potentially expensive pointer subtraction
drivers/net/wireless/b43legacy/phy.c:1304:31: warning: potentially expensive pointer subtraction
CHECK drivers/net/wireless/b43legacy/debugfs.c
drivers/net/wireless/b43legacy/debugfs.c:243:9: warning: memset with byte count of 131072
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/wireless/b43legacy/debugfs.c | 2 | ||||
| -rw-r--r-- | drivers/net/wireless/b43legacy/phy.c | 6 |
2 files changed, 3 insertions, 5 deletions
diff --git a/drivers/net/wireless/b43legacy/debugfs.c b/drivers/net/wireless/b43legacy/debugfs.c index 03ce082..1f85ac5 100644 --- a/drivers/net/wireless/b43legacy/debugfs.c +++ b/drivers/net/wireless/b43legacy/debugfs.c @@ -211,7 +211,7 @@ static ssize_t b43legacy_debugfs_read(struct file *file, char __user *userbuf, struct b43legacy_dfs_file *dfile; ssize_t uninitialized_var(ret); char *buf; - const size_t bufsize = 1024 * 128; + const size_t bufsize = 1024 * 16; /* 16 KiB buffer */ const size_t buforder = get_order(bufsize); int err = 0; diff --git a/drivers/net/wireless/b43legacy/phy.c b/drivers/net/wireless/b43legacy/phy.c index 4c9442b..11319ec 100644 --- a/drivers/net/wireless/b43legacy/phy.c +++ b/drivers/net/wireless/b43legacy/phy.c @@ -1296,12 +1296,10 @@ void b43legacy_lo_write(struct b43legacy_wldev *dev, /* Sanity check. */ if (pair->low < -8 || pair->low > 8 || pair->high < -8 || pair->high > 8) { - struct b43legacy_phy *phy = &dev->phy; b43legacydbg(dev->wl, "WARNING: Writing invalid LOpair " - "(low: %d, high: %d, index: %lu)\n", - pair->low, pair->high, - (unsigned long)(pair - phy->_lo_pairs)); + "(low: %d, high: %d)\n", + pair->low, pair->high); dump_stack(); } #endif |