diff options
author | Dominik Brodowski <linux@dominikbrodowski.net> | 2010-08-03 07:33:45 (GMT) |
---|---|---|
committer | Dominik Brodowski <linux@dominikbrodowski.net> | 2010-08-03 14:43:13 (GMT) |
commit | 127c03cdbad9bd5af5d7f33bd31a1015a90cb77f (patch) | |
tree | a948c5814a7d2e82801927bc3d5f06d3d7056ab0 /drivers/serial | |
parent | 0f52e86ded65749c6037473013ad77b2afa4f68d (diff) | |
download | linux-fsl-qoriq-127c03cdbad9bd5af5d7f33bd31a1015a90cb77f.tar.xz |
pcmcia: avoid buffer overflow in pcmcia_setup_isa_irq
NR_IRQS may be as low as 16, causing a (harmless?) buffer overflow in
pcmcia_setup_isa_irq():
static u8 pcmcia_used_irq[NR_IRQS];
...
if ((try < 32) && pcmcia_used_irq[irq])
continue;
This is read-only, so if this address would be non-zero, it would just
mean we would not attempt an IRQ >= NR_IRQS -- which would fail anyway!
And as request_irq() fails for an irq >= NR_IRQS, the setting code path:
pcmcia_used_irq[irq]++;
is never reached as well.
Reported-by: Christoph Fritz <chf.fritz@googlemail.com>
CC: stable@kernel.org
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
Signed-off-by: Christoph Fritz <chf.fritz@googlemail.com>
Diffstat (limited to 'drivers/serial')
0 files changed, 0 insertions, 0 deletions