diff options
| author | Kevin McKinney <klmckinney1@gmail.com> | 2011-10-07 22:50:12 (GMT) |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-10-11 16:18:21 (GMT) |
| commit | d491061b98bf3d2d036b9896f884403cdc2c0327 (patch) | |
| tree | c4128f9d7e020c6480dd9dd005cb74049aa56a99 /drivers/staging/bcm | |
| parent | 9d4f1d0c9d1cf2fc4a73b6fff30aa129b9d1586e (diff) | |
| download | linux-fsl-qoriq-d491061b98bf3d2d036b9896f884403cdc2c0327.tar.xz | |
Staging: bcm: Fix assignment issue in if statement reported by checkpatch.pl.
This patch fixes an error where an assignment "="
was being used in an if statement to determine if
Firmware was downloaded. This patch removes that
assignment, and places it above the if statement.
The if statement then evaluates the status to
verify if "0" successful, or != 0 failure.
Signed-off-by: Kevin McKinney <klmckinney1@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/bcm')
| -rw-r--r-- | drivers/staging/bcm/Misc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/staging/bcm/Misc.c b/drivers/staging/bcm/Misc.c index 0882e04..e9f29d5 100644 --- a/drivers/staging/bcm/Misc.c +++ b/drivers/staging/bcm/Misc.c @@ -1045,7 +1045,8 @@ int InitCardAndDownloadFirmware(PMINI_ADAPTER ps_adapter) } /* Download Firmare */ - if ((status = BcmFileDownload(ps_adapter, BIN_FILE, FIRMWARE_BEGIN_ADDR))) { + status = BcmFileDownload(ps_adapter, BIN_FILE, FIRMWARE_BEGIN_ADDR); + if (status != 0) { BCM_DEBUG_PRINT(ps_adapter, DBG_TYPE_INITEXIT, MP_INIT, DBG_LVL_ALL, "No Firmware File is present...\n"); goto OUT; } |