diff options
| author | Julia Lawall <julia@diku.dk> | 2011-04-01 14:23:44 (GMT) |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-04-20 21:11:47 (GMT) |
| commit | e2ce5049776f135b61fb87e9f8fad661f1d3c7ea (patch) | |
| tree | 191d644bdb48b576bf93eb64e74742dd2baa9920 /drivers/staging/cx25821/cx25821-video.c | |
| parent | 48c59f4b915caf4007e6d5a1f34b10fe10210b72 (diff) | |
| download | linux-fsl-qoriq-e2ce5049776f135b61fb87e9f8fad661f1d3c7ea.tar.xz | |
drivers/staging/cx25821/cx25821-video.c: introduce missing kfree
Error handling code following a kmalloc should free the allocated data.
The semantic match that finds the problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@
x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
when != if (...) { <+...x...+> }
(
x->f1 = E
|
(x->f1 == NULL || ...)
|
f(...,x->f1,...)
)
...>
(
return \(0\|<+...x...+>\|ptr\);
|
return@p2 ...;
)
@script:python@
p1 << r.p1;
p2 << r.p2;
@@
print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/staging/cx25821/cx25821-video.c')
| -rw-r--r-- | drivers/staging/cx25821/cx25821-video.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/staging/cx25821/cx25821-video.c b/drivers/staging/cx25821/cx25821-video.c index ab05392..04b18f4 100644 --- a/drivers/staging/cx25821/cx25821-video.c +++ b/drivers/staging/cx25821/cx25821-video.c @@ -832,6 +832,7 @@ static int video_open(struct file *file) if (NULL == dev) { mutex_unlock(&cx25821_devlist_mutex); + kfree(fh); return -ENODEV; } |