diff options
| author | Lidza Louina <lidza.louina@gmail.com> | 2013-08-29 23:00:37 (GMT) |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-08-30 18:28:58 (GMT) |
| commit | c211148fb6355f347ec819a05c3034acd56e75c1 (patch) | |
| tree | c0fe6a7abf161d0a20d479e405c6a2342c54b57b /drivers/staging/dgnc | |
| parent | f5adda3283fb4a2304a53e56699a9a0aadc3ab69 (diff) | |
| download | linux-fsl-qoriq-c211148fb6355f347ec819a05c3034acd56e75c1.tar.xz | |
staging: dgnc: adds TODO
This patchs adds a TODO for the driver.
Signed-off-by: Lidza Louina <lidza.louina@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/staging/dgnc')
| -rw-r--r-- | drivers/staging/dgnc/TODO | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/drivers/staging/dgnc/TODO b/drivers/staging/dgnc/TODO new file mode 100644 index 0000000..1ff2d18 --- /dev/null +++ b/drivers/staging/dgnc/TODO @@ -0,0 +1,17 @@ +* remove kzalloc casts +* checkpatch fixes +* sparse fixes +* fix use of sizeof(). Example replace sizeof(struct board_t) + with sizeof(*brd) and remove sizeof(char) +* change name of board_t to dgnc_board +* split two assignments into the two assignments on two lines; + don't use two equals signs +* remove unecessary comments +* remove unecessary error messages. Example kzalloc() has its + own error message. Adding an extra one is useless. +* use goto statements for error handling when appropriate +* there is a lot of unecessary code in the driver. It was + originally a standalone driver. Remove uneeded code. + +Please send patches to Greg Kroah-Hartman <greg@kroah.com> and +Cc: Lidza Louina <lidza.louina@gmail.com> |