diff options
| author | Marian Chereji <marian.chereji@freescale.com> | 2014-11-04 10:46:31 (GMT) |
|---|---|---|
| committer | Matthew Weigel <Matthew.Weigel@freescale.com> | 2014-12-11 18:40:24 (GMT) |
| commit | e6fdcaeb3c9c5e88b94fa472034c5bc4a3eefdca (patch) | |
| tree | 524ef55909ba802877f439fcbb413152caa8691c /drivers/staging | |
| parent | c21a39fb1bd60caf511c8c26abb803dca6bc5be2 (diff) | |
| download | linux-fsl-qoriq-e6fdcaeb3c9c5e88b94fa472034c5bc4a3eefdca.tar.xz | |
dpa_offload: Avoid double free of replicator group params in case of error
In dpa_classifier function "dpa_classif_mcast_create_group" the replicator
group params could be freed twice if the function "FM_PCD_FrmReplicSetGroup"
fails, for instance. The pointer is now reset at first free so that the second
free operation ignores it.
Change-Id: I8869db05157f68964bd2a131f6e184f78e64cf8c
Signed-off-by: Marian Chereji <marian.chereji@freescale.com>
Reviewed-on: http://git.am.freescale.net:8181/23108
Tested-by: Review Code-CDREVIEW <CDREVIEW@freescale.com>
Reviewed-by: Radu-Andrei Bulie <Radu.Bulie@freescale.com>
Reviewed-by: Richard Schmitt <richard.schmitt@freescale.com>
Diffstat (limited to 'drivers/staging')
| -rw-r--r-- | drivers/staging/fsl_dpa_offload/dpa_classifier.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/staging/fsl_dpa_offload/dpa_classifier.c b/drivers/staging/fsl_dpa_offload/dpa_classifier.c index 65bc333..20b0143 100644 --- a/drivers/staging/fsl_dpa_offload/dpa_classifier.c +++ b/drivers/staging/fsl_dpa_offload/dpa_classifier.c @@ -7972,6 +7972,7 @@ int dpa_classif_mcast_create_group( } kfree(replic_grp_params); + replic_grp_params = NULL; if (!pgroup->group) { log_err("Could not create %s group %d\n", |