summaryrefslogtreecommitdiff
path: root/drivers/target/iscsi/iscsi_target_login.c
diff options
context:
space:
mode:
authorRoland Dreier <roland@purestorage.com>2013-06-05 16:54:17 (GMT)
committerNicholas Bellinger <nab@linux-iscsi.org>2013-06-14 08:12:56 (GMT)
commitb5aff3d2747bea08b386edd070941a45611ffe51 (patch)
treec08e9c472d39f54580f310c65b6030c276eca908 /drivers/target/iscsi/iscsi_target_login.c
parent574780fd5e6ec52bd43e0bdb777a19e4c4c6aa9c (diff)
downloadlinux-fsl-qoriq-b5aff3d2747bea08b386edd070941a45611ffe51.tar.xz
tcm_qla2xxx: Fix residual for underrun commands that fail
Suppose an initiator sends a DATA IN command with an allocation length shorter than the FC transfer length -- we get a target message like TARGET_CORE[qla2xxx]: Expected Transfer Length: 256 does not match SCSI CDB Length: 0 for SAM Opcode: 0x12 In that case, the target core adjusts the data_length and sets se_cmd->residual_count for the underrun. But now suppose that command fails and we end up in tcm_qla2xxx_queue_status() -- that function unconditionally overwrites residual_count with the already adjusted data_length, and the initiator will burp with a message like qla2xxx [0000:00:06.0]-301d:0: Dropped frame(s) detected (0x100 of 0x100 bytes). Fix this by adding on to the existing underflow residual count instead. Signed-off-by: Roland Dreier <roland@purestorage.com> Cc: Giridhar Malavali <giridhar.malavali@qlogic.com> Cc: Chad Dupuis <chad.dupuis@qlogic.com> Cc: stable <stable@vger.kernel.org> Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target/iscsi/iscsi_target_login.c')
0 files changed, 0 insertions, 0 deletions