diff options
author | Roland Dreier <roland@purestorage.com> | 2012-10-31 16:16:45 (GMT) |
---|---|---|
committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2012-11-01 07:38:44 (GMT) |
commit | 3e03989b5868acf69a391a424dc71fcd6cc48167 (patch) | |
tree | c187fcbe2d9861d10e9256725990f266da1f246d /drivers/target/iscsi/iscsi_target_util.h | |
parent | 0d0f9dfb31e0a6c92063e235417b42df185b3275 (diff) | |
download | linux-fsl-qoriq-3e03989b5868acf69a391a424dc71fcd6cc48167.tar.xz |
target: Avoid integer overflow in se_dev_align_max_sectors()
The expression (max_sectors * block_size) might overflow a u32
(indeed, since iblock sets max_hw_sectors to UINT_MAX, it is
guaranteed to overflow and end up with a much-too-small result in many
common cases). Fix this by doing an equivalent calculation that
doesn't require multiplication.
While we're touching this code, avoid splitting a printk format across
two lines and use pr_info(...) instead of printk(KERN_INFO ...).
Signed-off-by: Roland Dreier <roland@purestorage.com>
Cc: stable@vger.kernel.org
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/target/iscsi/iscsi_target_util.h')
0 files changed, 0 insertions, 0 deletions