summaryrefslogtreecommitdiff
path: root/drivers/target/target_core_sbc.c
diff options
context:
space:
mode:
authorOleg Nesterov <oleg@redhat.com>2013-09-11 21:24:42 (GMT)
committerLinus Torvalds <torvalds@linux-foundation.org>2013-09-11 22:59:05 (GMT)
commit92eaa565add62d56b90987f58ea9feafc5a7c183 (patch)
tree78f7bfaa0b99b2b2f5b554bc883b67ac68412e21 /drivers/target/target_core_sbc.c
parent52f14282bb0c3d3e5ba2a9eaacb12ff37a033e7e (diff)
downloadlinux-fsl-qoriq-92eaa565add62d56b90987f58ea9feafc5a7c183.tar.xz
exec: kill ->load_binary != NULL check in search_binary_handler()
search_binary_handler() checks ->load_binary != NULL for no reason, this method should be always defined. Turn this check into WARN_ON() and move it into __register_binfmt(). Also, kill the function pointer. The current code looks confusing, as if ->load_binary can go away after read_unlock(&binfmt_lock). But we rely on module_get(fmt->module), this fmt can't be changed or unregistered, otherwise this code is buggy anyway. Signed-off-by: Oleg Nesterov <oleg@redhat.com> Acked-by: Kees Cook <keescook@chromium.org> Cc: Al Viro <viro@ZenIV.linux.org.uk> Cc: Evgeniy Polyakov <zbr@ioremap.net> Cc: Zach Levis <zml@linux.vnet.ibm.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/target/target_core_sbc.c')
0 files changed, 0 insertions, 0 deletions