diff options
author | Marko Katic <dromede@gmail.com> | 2012-12-18 00:01:14 (GMT) |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2012-12-18 01:15:17 (GMT) |
commit | 1581b088fc91cbb974ad2b98431a8ecabb4852ee (patch) | |
tree | b389afd9898585754489a9811b55caa0227c2a62 /drivers/video/backlight/vgg2432a4.c | |
parent | 1eddd9770f7e809228ae761ecc575f214f571e51 (diff) | |
download | linux-fsl-qoriq-1581b088fc91cbb974ad2b98431a8ecabb4852ee.tar.xz |
backlight: corgi_lcd: Use gpio_set_value_cansleep() to avoid WARN_ON
Changing backlight intensity on an Akita (Sharp Zaurus C-1000) triggers
WARN_ON message:
WARNING: at drivers/gpio/gpiolib.c:1672 __gpio_set_value+0x38/0xa4()
Modules linked in:
Backtrace:
corgi_bl_set_intensity+0x0/0x74
corgi_bl_update_status+0x0/0x64
corgi_lcd_probe+0x0/0x258
spi_drv_probe+0x0/0x24
driver_probe_device+0x0/0x208
__driver_attach+0x0/0x94
bus_for_each_dev+0x0/0x90
driver_attach+0x0/0x28
bus_add_driver+0x0/0x22c
driver_register+0x0/0x134
spi_register_driver+0x0/0x60
corgi_lcd_driver_init+0x0/0x1c
do_one_initcall+0x0/0x174
kernel_init+0x0/0x2a8
Akita machines have backlight controls hooked to a gpio expander chip,
max7310 using i2c transfers which can sleep. In this case,
pca953x_gpio_set_value() can be called to control gpio, and
pca953x_setup_gpio() sets can_sleep flag. Therefore,
gpio_set_value_cansleep() should be used in order to avoid WARN_ON on
akita machines.
Akita is the only exception in this case since other users of corgi_lcd
access backlight gpio controls through a different gpio expander which
does not set the can_sleep flag.
Signed-off-by: Marko Katic <dromede@gmail.com>
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'drivers/video/backlight/vgg2432a4.c')
0 files changed, 0 insertions, 0 deletions