summaryrefslogtreecommitdiff
path: root/drivers/video/broadsheetfb.c
diff options
context:
space:
mode:
authorJames Bates <james.h.bates@gmail.com>2013-10-02 16:43:39 (GMT)
committerTomi Valkeinen <tomi.valkeinen@ti.com>2013-10-29 10:41:46 (GMT)
commit55aa42f2e690157e254a6a6989f5f4ac928b35c8 (patch)
treed3fcbcc20f2a6e167335dab8ceaeb5bdc23fa41b /drivers/video/broadsheetfb.c
parente8ddb0cfa18dfa4d85d6c420c967850d430b07c6 (diff)
downloadlinux-fsl-qoriq-55aa42f2e690157e254a6a6989f5f4ac928b35c8.tar.xz
efifb: prevent null-deref when iterating dmi_list
The dmi_list array is initialized using gnu designated initializers, and therefore may contain fewer explicitly defined entries as there are elements in it. This is because the enum above with M_xyz constants contains more items than the designated initializer. Those elements not explicitly initialized are implicitly set to 0. Now efifb_setup() loops through all these array elements, and performs a strcmp on each item. For non explicitly initialized elements this will be a null pointer: This patch swaps the check order in the if statement, thus checks first whether dmi_list[i].base is null. Signed-off-by: James Bates <james.h.bates@gmail.com> Signed-off-by: David Herrmann <dh.herrmann@gmail.com> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Diffstat (limited to 'drivers/video/broadsheetfb.c')
0 files changed, 0 insertions, 0 deletions