diff options
author | Peter Huewe <peterhuewe@gmx.de> | 2013-02-13 14:28:14 (GMT) |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-02-13 17:33:38 (GMT) |
commit | fc9ca48eb60f4a516f59bbde1dc7685744ceb310 (patch) | |
tree | 260126093f2f3f6b4e5465272b34bab0ca786f53 /drivers/watchdog/pnx833x_wdt.c | |
parent | b7e6724238409d0985dcf7219dd9eb0a1f58e7e5 (diff) | |
download | linux-fsl-qoriq-fc9ca48eb60f4a516f59bbde1dc7685744ceb310.tar.xz |
staging/comedi: Fix undefined array subscript
In vmk80xx_do_insn_bits the local variable reg, which is used as an
index to the tx_buf array, can be used uninitialized if
- data[0] == 0
and
- devpriv->model != VMK8061_MODEL
-> we get into the else branch without having reg initialized.
Since the driver usually differentiates between VMK8061_MODEL and
VMK8055_MODEL it's safe to assume that VMK8055_DO_REG was meant as an
initial value.
And to avoid duplication we can move the assignments to the top.
Acked-by: Ian Abbott <abbotti@mev.co.uk>
Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/watchdog/pnx833x_wdt.c')
0 files changed, 0 insertions, 0 deletions