diff options
author | Russell King <rmk+kernel@arm.linux.org.uk> | 2012-04-14 17:57:10 (GMT) |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2012-04-23 15:54:21 (GMT) |
commit | 354535845ffb74d8a4827fbdaa493037d0030eea (patch) | |
tree | db21db97f7672f426d21dc8d0097b8b4c38d02fc /firmware/ihex2fw.c | |
parent | 754aba436bed2051deaa2af7bdda553df056b6fc (diff) | |
download | linux-fsl-qoriq-354535845ffb74d8a4827fbdaa493037d0030eea.tar.xz |
ARM: OMAP: fix DMA vs memory ordering
Using coherent DMA memory with the OMAP DMA engine results in
unpredictable behaviour due to memory ordering issues; as things stand,
there is no guarantee that data written to coherent DMA memory will be
visible to the DMA hardware.
This is because the OMAP dma_write() accessor contains no barriers,
necessary on ARMv6 and above. The effect of this can be seen in comments
in the OMAP serial driver, which incorrectly talks about cache flushing
for the coherent DMA stuff.
Rather than adding barriers to the accessors, add it in the DMA support
code just before we enable DMA, and just after we disable DMA. This
avoids having barriers for every DMA register access.
Acked-by: Tony Lindgren <tony@atomide.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'firmware/ihex2fw.c')
0 files changed, 0 insertions, 0 deletions