diff options
author | Trond Myklebust <Trond.Myklebust@netapp.com> | 2005-08-16 15:49:44 (GMT) |
---|---|---|
committer | Linus Torvalds <torvalds@g5.osdl.org> | 2005-08-16 16:30:58 (GMT) |
commit | 65e4308d2500e7daf60c3dccc202c61ffb066c63 (patch) | |
tree | 76a2e00004f645d09b2e59b485fb2aea0af45234 /fs/locks.c | |
parent | 367ae3cd74bdc2ad32d71293427fec570b14ddcd (diff) | |
download | linux-fsl-qoriq-65e4308d2500e7daf60c3dccc202c61ffb066c63.tar.xz |
[PATCH] NFS: Ensure we always update inode->i_mode when doing O_EXCL creates
When the client performs an exclusive create and opens the file for writing,
a Netapp filer will first create the file using the mode 01777. It does this
since an NFSv3/v4 exclusive create cannot immediately set the mode bits.
The 01777 mode then gets put into the inode->i_mode. After the file creation
is successful, we then do a setattr to change the mode to the correct value
(as per the NFS spec).
The problem is that nfs_refresh_inode() no longer updates inode->i_mode, so
the latter retains the 01777 mode. A bit later, the VFS notices this, and calls
remove_suid(). This of course now resets the file mode to inode->i_mode & 0777.
Hey presto, the file mode on the server is now magically changed to 0777. Duh...
Fixes http://bugzilla.linux-nfs.org/show_bug.cgi?id=32
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'fs/locks.c')
0 files changed, 0 insertions, 0 deletions