summaryrefslogtreecommitdiff
path: root/fs/xfs/xfs_log.h
diff options
context:
space:
mode:
authorCarlos Maiolino <cmaiolino@redhat.com>2011-11-07 16:10:24 (GMT)
committerAlex Elder <aelder@sgi.com>2011-11-08 16:48:23 (GMT)
commitb52a360b2aa1c59ba9970fb0f52bbb093fcc7a24 (patch)
treeb8710ad524592faac1427d2155aaf4ba29a80cf8 /fs/xfs/xfs_log.h
parent1ea6b8f48918282bdca0b32a34095504ee65bab5 (diff)
downloadlinux-fsl-qoriq-b52a360b2aa1c59ba9970fb0f52bbb093fcc7a24.tar.xz
xfs: Fix possible memory corruption in xfs_readlink
Fixes a possible memory corruption when the link is larger than MAXPATHLEN and XFS_DEBUG is not enabled. This also remove the S_ISLNK assert, since the inode mode is checked previously in xfs_readlink_by_handle() and via VFS. Updated to address concerns raised by Ben Hutchings about the loose attention paid to 32- vs 64-bit values, and the lack of handling a potentially negative pathlen value: - Changed type of "pathlen" to be xfs_fsize_t, to match that of ip->i_d.di_size - Added checking for a negative pathlen to the too-long pathlen test, and generalized the message that gets reported in that case to reflect the change As a result, if a negative pathlen were encountered, this function would return EFSCORRUPTED (and would fail an assertion for a debug build)--just as would a too-long pathlen. Signed-off-by: Alex Elder <aelder@sgi.com> Signed-off-by: Carlos Maiolino <cmaiolino@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'fs/xfs/xfs_log.h')
0 files changed, 0 insertions, 0 deletions