diff options
author | Dave Chinner <dchinner@redhat.com> | 2010-11-30 04:16:16 (GMT) |
---|---|---|
committer | Alex Elder <aelder@sgi.com> | 2010-12-01 13:40:20 (GMT) |
commit | 90810b9e82a36c3c57c1aeb8b2918b242a130b26 (patch) | |
tree | 2fdb8bd75866fc3d61cb7fe2f2cc26f0e6895641 /fs/xfs/xfs_log_recover.h | |
parent | c726de4409a8d3a03877b1ef4342bfe8a15f5e5e (diff) | |
download | linux-fsl-qoriq-90810b9e82a36c3c57c1aeb8b2918b242a130b26.tar.xz |
xfs: push stale, pinned buffers on trylock failures
As reported by Nick Piggin, XFS is suffering from long pauses under
highly concurrent workloads when hosted on ramdisks. The problem is
that an inode buffer is stuck in the pinned state in memory and as a
result either the inode buffer or one of the inodes within the
buffer is stopping the tail of the log from being moved forward.
The system remains in this state until a periodic log force issued
by xfssyncd causes the buffer to be unpinned. The main problem is
that these are stale buffers, and are hence held locked until the
transaction/checkpoint that marked them state has been committed to
disk. When the filesystem gets into this state, only the xfssyncd
can cause the async transactions to be committed to disk and hence
unpin the inode buffer.
This problem was encountered when scaling the busy extent list, but
only the blocking lock interface was fixed to solve the problem.
Extend the same fix to the buffer trylock operations - if we fail to
lock a pinned, stale buffer, then force the log immediately so that
when the next attempt to lock it comes around, it will have been
unpinned.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Diffstat (limited to 'fs/xfs/xfs_log_recover.h')
0 files changed, 0 insertions, 0 deletions