summaryrefslogtreecommitdiff
path: root/fs
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2014-02-13 18:29:31 (GMT)
committerJiri Slaby <jslaby@suse.cz>2014-03-05 16:13:43 (GMT)
commit2c561a28bfeafc587b9d1ecc0b3c0568c2489ee7 (patch)
tree2a5f702a98798ebd16f89b6f8983ece4d3157c53 /fs
parent3e507fa19fea1d5423f4be675fd211c52f7c12c4 (diff)
downloadlinux-fsl-qoriq-2c561a28bfeafc587b9d1ecc0b3c0568c2489ee7.tar.xz
cgroup: update cgroup_enable_task_cg_lists() to grab siglock
commit 532de3fc72adc2a6525c4d53c07bf81e1732083d upstream. Currently, there's nothing preventing cgroup_enable_task_cg_lists() from missing set PF_EXITING and race against cgroup_exit(). Depending on the timing, cgroup_exit() may finish with the task still linked on css_set leading to list corruption. Fix it by grabbing siglock in cgroup_enable_task_cg_lists() so that PF_EXITING is guaranteed to be visible. This whole on-demand cg_list optimization is extremely fragile and has ample possibility to lead to bugs which can cause things like once-a-year oops during boot. I'm wondering whether the better approach would be just adding "cgroup_disable=all" handling which disables the whole cgroup rather than tempting fate with this on-demand craziness. Signed-off-by: Tejun Heo <tj@kernel.org> Acked-by: Li Zefan <lizefan@huawei.com> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Diffstat (limited to 'fs')
0 files changed, 0 insertions, 0 deletions