diff options
author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2013-06-05 22:17:25 (GMT) |
---|---|---|
committer | Dave Airlie <airlied@redhat.com> | 2013-06-27 10:34:16 (GMT) |
commit | 160954b7bca43da7cd3cfbce310e6df919a8216e (patch) | |
tree | c10b295d21363961641e452a92bb8179e05106f0 /include/drm/drm_crtc.h | |
parent | 2b54f78190a2683f48f1295a4c28e98df042546a (diff) | |
download | linux-fsl-qoriq-160954b7bca43da7cd3cfbce310e6df919a8216e.tar.xz |
drm: kms_helper: don't lose hotplug event
There's a race window (small for hpd, 10s large for polled outputs)
where userspace could sneak in with an unrelated connnector probe
ioctl call and eat the hotplug event (since neither the hpd nor the
poll code see a state change).
To avoid this, check whether the connector state changes in all other
->detect calls (in the current helper code that's only probe_single)
and if that's the case, fire off a hotplug event. Note that we can't
directly call the hotplug event handler, since that expects that no
locks are held (due to reentrancy with the fb code to update the kms
console).
Also, this requires that drivers using the probe_single helper
function set up the poll work. All current drivers do that already,
and with the reworked hpd handling there'll be no downside to
unconditionally setting up the poll work any more.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Dave Airlie <airlied@redhat.com>
Diffstat (limited to 'include/drm/drm_crtc.h')
-rw-r--r-- | include/drm/drm_crtc.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index b9ddd3d..0fd007a 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -808,6 +808,7 @@ struct drm_mode_config { /* output poll support */ bool poll_enabled; bool poll_running; + bool delayed_event; struct delayed_work output_poll_work; /* pointers to standard properties */ |