diff options
author | Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> | 2010-09-09 02:47:49 (GMT) |
---|---|---|
committer | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2010-09-10 15:07:40 (GMT) |
commit | f4363b7d88e99497e4241397efee09b106d802c4 (patch) | |
tree | 668a3b3cebc4b4efe9e6b89a28993d1ee2acfe13 /include/video | |
parent | 5fbdedf072500859601705fa6f07a9e895d5e3a8 (diff) | |
download | linux-fsl-qoriq-f4363b7d88e99497e4241397efee09b106d802c4.tar.xz |
fbdev: sh_mobile_hdmi: modify noisy comment out
This patch solve below report from Guennadi
1)
> - hdmi_write(hdmi, 0x00, HDMI_AUDIO_SETTING_1);
> + switch (pdata->flags & HDMI_SRC_MASK) {
> + default:
> + /* FALL THROUGH */
I'm not sure I like the capitalisation here - no reason to shout;)
2)
> +/************************************************************************
> +
> +
> + HDMI sound
> +
> +
> +************************************************************************/
I don't think this comment deserves 7 lines of text, besides breaking the
multiline comment style. If you think, one line like
/* HDMI sound */
is not enough how about just
/*
* HDMI sound
*/
3)
> +/************************************************************************
> +
> +
> + HDMI video
> +
> +
> +************************************************************************/
See above - 7 lines seem to be an overkill to me.
Reported-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'include/video')
0 files changed, 0 insertions, 0 deletions