summaryrefslogtreecommitdiff
path: root/init/do_mounts_md.c
diff options
context:
space:
mode:
authorNeilBrown <neilb@suse.de>2013-06-12 01:01:22 (GMT)
committerNeilBrown <neilb@suse.de>2013-06-13 03:40:48 (GMT)
commite2d59925221cd562e07fee38ec8839f7209ae603 (patch)
tree35ac67de5be7d4a96c2c3f9665f9d7d68b52e8dd /init/do_mounts_md.c
parent3056e3aec8d8ba61a0710fb78b2d562600aa2ea7 (diff)
downloadlinux-fsl-qoriq-e2d59925221cd562e07fee38ec8839f7209ae603.tar.xz
md/raid1,raid10: use freeze_array in place of raise_barrier in various places.
Various places in raid1 and raid10 are calling raise_barrier when they really should call freeze_array. The former is only intended to be called from "make_request". The later has extra checks for 'nr_queued' and makes a call to flush_pending_writes(), so it is safe to call it from within the management thread. Using raise_barrier will sometimes deadlock. Using freeze_array should not. As 'freeze_array' currently expects one request to be pending (in handle_read_error - the only previous caller), we need to pass it the number of pending requests (extra) to ignore. The deadlock was made particularly noticeable by commits 050b66152f87c7 (raid10) and 6b740b8d79252f13 (raid1) which appeared in 3.4, so the fix is appropriate for any -stable kernel since then. This patch probably won't apply directly to some early kernels and will need to be applied by hand. Cc: stable@vger.kernel.org Reported-by: Alexander Lyakas <alex.bolshoy@gmail.com> Signed-off-by: NeilBrown <neilb@suse.de>
Diffstat (limited to 'init/do_mounts_md.c')
0 files changed, 0 insertions, 0 deletions