diff options
author | Tiejun Chen <tiejun.chen@windriver.com> | 2013-12-18 09:51:49 (GMT) |
---|---|---|
committer | Scott Wood <scottwood@freescale.com> | 2014-05-14 18:38:30 (GMT) |
commit | b620520208efe1fc8aef893a09374cab7c10c68d (patch) | |
tree | e1289091ea55aef89e64c446833c1dc34ac3aae2 /kernel/notifier.c | |
parent | 9e20ed4e1caedf12d0cafe3542ce95a937cd11da (diff) | |
download | linux-fsl-qoriq-b620520208efe1fc8aef893a09374cab7c10c68d.tar.xz |
rcutree/rcu_bh_qs: disable irq while calling rcu_preempt_qs()
Any callers to the function rcu_preempt_qs() must disable irqs in
order to protect the assignment to ->rcu_read_unlock_special. In
RT case, rcu_bh_qs() as the wrapper of rcu_preempt_qs() is called
in some scenarios where irq is enabled, like this path,
do_single_softirq()
|
+ local_irq_enable();
+ handle_softirq()
| |
| + rcu_bh_qs()
| |
| + rcu_preempt_qs()
|
+ local_irq_disable()
So here we'd better disable irq directly inside of rcu_bh_qs() to
fix this, otherwise the kernel may be freezable sometimes as
observed. And especially this way is also kind and safe for the
potential rcu_bh_qs() usage elsewhere in the future.
Cc: stable-rt@vger.kernel.org
Signed-off-by: Tiejun Chen <tiejun.chen@windriver.com>
Signed-off-by: Bin Jiang <bin.jiang@windriver.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Diffstat (limited to 'kernel/notifier.c')
0 files changed, 0 insertions, 0 deletions