diff options
author | Yong Zhang <yong.zhang0@gmail.com> | 2011-10-16 10:56:44 (GMT) |
---|---|---|
committer | Scott Wood <scottwood@freescale.com> | 2014-05-14 18:38:16 (GMT) |
commit | 56f80222141ae1bd22f5494d9bf96d074882fb5a (patch) | |
tree | 69cdf6aa50c2b582859b8ccb742b7afacd15f767 /kernel/tsacct.c | |
parent | 00341ee7b76da430fcb63ccc5717991cb4a14bad (diff) | |
download | linux-fsl-qoriq-56f80222141ae1bd22f5494d9bf96d074882fb5a.tar.xz |
hotplug: Call cpu_unplug_begin() before DOWN_PREPARE
cpu_unplug_begin() should be called before CPU_DOWN_PREPARE, because
at CPU_DOWN_PREPARE cpu_active is cleared and sched_domain is
rebuilt. Otherwise the 'sync_unplug' thread will be running on the cpu
on which it's created and not bound on the cpu which is about to go
down.
I found that by an incorrect warning on smp_processor_id() called by
sync_unplug/1, and trace shows below:
(echo 1 > /sys/device/system/cpu/cpu1/online)
bash-1664 [000] 83.136620: _cpu_down: Bind sync_unplug to cpu 1
bash-1664 [000] 83.136623: sched_wait_task: comm=sync_unplug/1 pid=1724 prio=120
bash-1664 [000] 83.136624: _cpu_down: Wake sync_unplug
bash-1664 [000] 83.136629: sched_wakeup: comm=sync_unplug/1 pid=1724 prio=120 success=1 target_cpu=000
Wants to be folded back....
Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Link: http://lkml.kernel.org/r/1318762607-2261-3-git-send-email-yong.zhang0@gmail.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'kernel/tsacct.c')
0 files changed, 0 insertions, 0 deletions