diff options
| author | Oleg Nesterov <oleg@redhat.com> | 2010-05-26 21:43:04 (GMT) |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2010-05-27 16:12:45 (GMT) |
| commit | d47419cd967a4f032a194148a7b08afad32faded (patch) | |
| tree | b330b3adbaf1b2528b663322adff11a2761cb4b4 /lib/kasprintf.c | |
| parent | 7d64224217b53b23243fd2aa428001486f2a5da5 (diff) | |
| download | linux-fsl-qoriq-d47419cd967a4f032a194148a7b08afad32faded.tar.xz | |
call_usermodehelper: simplify/fix UMH_NO_WAIT case
__call_usermodehelper(UMH_NO_WAIT) has 2 problems:
- if kernel_thread() fails, call_usermodehelper_freeinfo()
is not called.
- for unknown reason UMH_NO_WAIT has UMH_WAIT_PROC logic,
we spawn yet another thread which waits until the user
mode application exits.
Change the UMH_NO_WAIT code to use ____call_usermodehelper() instead of
wait_for_helper(), and do call_usermodehelper_freeinfo() unconditionally.
We can rely on CLONE_VFORK, do_fork(CLONE_VFORK) until the child exits or
execs.
With or without this patch UMH_NO_WAIT does not report the error if
kernel_thread() fails, this is correct since the caller doesn't wait for
result.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib/kasprintf.c')
0 files changed, 0 insertions, 0 deletions