diff options
| author | Marek Lindner <lindner_marek@yahoo.de> | 2011-02-10 14:33:51 (GMT) |
|---|---|---|
| committer | Marek Lindner <lindner_marek@yahoo.de> | 2011-03-05 11:50:07 (GMT) |
| commit | ed75ccbe26f4a672a41556120390e67c80a2c441 (patch) | |
| tree | 3f4f844d2311e662b4c42e7a275188d1346ac77d /net/batman-adv/types.h | |
| parent | 7d2b554826195372764910da2f0dcb0d9b869108 (diff) | |
| download | linux-fsl-qoriq-ed75ccbe26f4a672a41556120390e67c80a2c441.tar.xz | |
batman-adv: Correct rcu refcounting for batman_if
It might be possible that 2 threads access the same data in the same
rcu grace period. The first thread calls call_rcu() to decrement the
refcount and free the data while the second thread increases the
refcount to use the data. To avoid this race condition all refcount
operations have to be atomic.
Reported-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Diffstat (limited to 'net/batman-adv/types.h')
| -rw-r--r-- | net/batman-adv/types.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/batman-adv/types.h b/net/batman-adv/types.h index 96f7c22..e0140c6 100644 --- a/net/batman-adv/types.h +++ b/net/batman-adv/types.h @@ -43,7 +43,7 @@ struct batman_if { unsigned char *packet_buff; int packet_len; struct kobject *hardif_obj; - struct kref refcount; + atomic_t refcount; struct packet_type batman_adv_ptype; struct net_device *soft_iface; struct rcu_head rcu; |