summaryrefslogtreecommitdiff
path: root/net/bluetooth/hci_core.c
diff options
context:
space:
mode:
authorDavid Herrmann <dh.herrmann@googlemail.com>2011-11-01 16:27:50 (GMT)
committerGustavo F. Padovan <padovan@profusion.mobi>2011-11-07 19:24:54 (GMT)
commit25df0845e054f70a8735ee0184739472d8a573c9 (patch)
tree090ca61b8fbe3f97e4f5549ebe444ea5ea8fa728 /net/bluetooth/hci_core.c
parent7f103a0d23d2778b86cea407c1992522d41ead81 (diff)
downloadlinux-fsl-qoriq-25df0845e054f70a8735ee0184739472d8a573c9.tar.xz
Bluetooth: hidp: Fix module reference cleanup
Calling module_put(THIS_MODULE) is *never* safe when we cannot go sure that we own at least two references. This is because the call may unload our module before it returns and then the "return" will jump into invalid memory. Gladly, module.h provides a wrapper for kthread-users: module_put_and_exit(). This puts our module and then exits the kthread without returning to the module. This patch fixes the hidp kthread to use this wrapper instead of manually freeing its own reference. See nfsd or lockd for other kthreads using this. Calling __module_get() inside the kthread is safe as the hidp module will always wait until the kthread sets "waiting_for_startup" to 0. Signed-off-by: David Herrmann <dh.herrmann@googlemail.com> Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
Diffstat (limited to 'net/bluetooth/hci_core.c')
0 files changed, 0 insertions, 0 deletions