diff options
| author | David S. Miller <davem@davemloft.net> | 2010-08-02 22:07:58 (GMT) |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-08-02 22:07:58 (GMT) |
| commit | 83bf2e4089bebc2c7fd14a79de5954b26fe8d4af (patch) | |
| tree | ab2cb1f229ba4c2d7236406c997e41a223daf74d /net/ipv4/netfilter/nf_nat_proto_icmp.c | |
| parent | de38483010bae523f533bb6bf9f7b7353772f6eb (diff) | |
| parent | 6661481d5a8975657742c7ed40ae16bdaa7d0a6e (diff) | |
| download | linux-fsl-qoriq-83bf2e4089bebc2c7fd14a79de5954b26fe8d4af.tar.xz | |
Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/kaber/nf-next-2.6
Diffstat (limited to 'net/ipv4/netfilter/nf_nat_proto_icmp.c')
| -rw-r--r-- | net/ipv4/netfilter/nf_nat_proto_icmp.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/net/ipv4/netfilter/nf_nat_proto_icmp.c b/net/ipv4/netfilter/nf_nat_proto_icmp.c index 19a8b0b..5744c3e 100644 --- a/net/ipv4/netfilter/nf_nat_proto_icmp.c +++ b/net/ipv4/netfilter/nf_nat_proto_icmp.c @@ -27,7 +27,7 @@ icmp_in_range(const struct nf_conntrack_tuple *tuple, ntohs(tuple->src.u.icmp.id) <= ntohs(max->icmp.id); } -static bool +static void icmp_unique_tuple(struct nf_conntrack_tuple *tuple, const struct nf_nat_range *range, enum nf_nat_manip_type maniptype, @@ -42,13 +42,13 @@ icmp_unique_tuple(struct nf_conntrack_tuple *tuple, if (!(range->flags & IP_NAT_RANGE_PROTO_SPECIFIED)) range_size = 0xFFFF; - for (i = 0; i < range_size; i++, id++) { + for (i = 0; ; ++id) { tuple->src.u.icmp.id = htons(ntohs(range->min.icmp.id) + (id % range_size)); - if (!nf_nat_used_tuple(tuple, ct)) - return true; + if (++i == range_size || !nf_nat_used_tuple(tuple, ct)) + return; } - return false; + return; } static bool |