diff options
author | H Hartley Sweeten <hsweeten@visionengravers.com> | 2010-01-08 08:53:03 (GMT) |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2010-01-08 08:53:03 (GMT) |
commit | df2f7ec8c09ce879245c3309d859218188123ef1 (patch) | |
tree | 423d022048f001c5c073e6380b846b158eab2033 /net/ipv6/tcp_ipv6.c | |
parent | e2eb8e38592f28d8be4a518f44d3385272dedddb (diff) | |
download | linux-fsl-qoriq-df2f7ec8c09ce879245c3309d859218188123ef1.tar.xz |
ep93xx_eth.c general cleanup
General cleanup of the ep93xx_eth driver.
1) Use pr_fmt() to prefix the module name and __func__ to the error
messages.
2) <linux/io.h> instead of <asm/io.h>
3) <mach/hardware.h> instead of <mach/ep93xx-regs.h> and <mach/platform.h>
4) Move the ep93xx_mdio_read (and ep93xx_mdio_write) function to eliminate
the function prototype.
5) Change all the printk(<level> messages to pr_<level> and remove the
__func__ argument.
6) Use platform_get_{resource/irq} to get the platform resources and add
an error check.
7) Use resource_size() for request_mem_region() and ioremap().
8) Use %pM to print the MAC address at the end of the probe.
9) Use dev->dev_addr not data->dev_addr for the MAC argument because a
random address could be used if the platform does not supply one.
The message at the end of the probe is left as a printk since it displays
cleaner without the function name that would be displayed with pr_info().
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Acked-by: Lennert Buytenhek <kernel@wantstofly.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/tcp_ipv6.c')
0 files changed, 0 insertions, 0 deletions