diff options
| author | Hans Schillstrom <hans.schillstrom@ericsson.com> | 2011-06-13 07:06:57 (GMT) |
|---|---|---|
| committer | Simon Horman <horms@verge.net.au> | 2011-06-13 08:41:47 (GMT) |
| commit | 8f4e0a18682d91abfad72ede3d3cb5f3ebdf54b4 (patch) | |
| tree | b2b5ec39519bbf6416ae021f108739290e565b50 /net/netfilter/ipvs/ip_vs_core.c | |
| parent | d232b8dded624af3e346b13807a591c63b601c44 (diff) | |
| download | linux-fsl-qoriq-8f4e0a18682d91abfad72ede3d3cb5f3ebdf54b4.tar.xz | |
IPVS netns exit causes crash in conntrack
Quote from Patric Mc Hardy
"This looks like nfnetlink.c excited and destroyed the nfnl socket, but
ip_vs was still holding a reference to a conntrack. When the conntrack
got destroyed it created a ctnetlink event, causing an oops in
netlink_has_listeners when trying to use the destroyed nfnetlink
socket."
If nf_conntrack_netlink is loaded before ip_vs this is not a problem.
This patch simply avoids calling ip_vs_conn_drop_conntrack()
when netns is dying as suggested by Julian.
Signed-off-by: Hans Schillstrom <hans.schillstrom@ericsson.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
Diffstat (limited to 'net/netfilter/ipvs/ip_vs_core.c')
| -rw-r--r-- | net/netfilter/ipvs/ip_vs_core.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/netfilter/ipvs/ip_vs_core.c b/net/netfilter/ipvs/ip_vs_core.c index 55af224..24c28d2 100644 --- a/net/netfilter/ipvs/ip_vs_core.c +++ b/net/netfilter/ipvs/ip_vs_core.c @@ -1945,6 +1945,7 @@ static void __net_exit __ip_vs_dev_cleanup(struct net *net) { EnterFunction(2); net_ipvs(net)->enable = 0; /* Disable packet reception */ + smp_wmb(); __ip_vs_sync_cleanup(net); LeaveFunction(2); } |