diff options
| author | stephen hemminger <shemminger@vyatta.com> | 2010-08-23 10:24:18 (GMT) |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-08-24 03:43:16 (GMT) |
| commit | 0fdc100bdc4b7ab61ed632962c76dfe539047296 (patch) | |
| tree | 354e79b15b101a2ace627ce08779e4ef40c1e477 /net | |
| parent | afdcba371f9748ac91608bb6c57f170aab7085b4 (diff) | |
| download | linux-fsl-qoriq-0fdc100bdc4b7ab61ed632962c76dfe539047296.tar.xz | |
ethtool: allow non-netadmin to query settings
The SNMP daemon uses ethtool to determine the speed of
network interfaces. This fails on Debian (and probably elsewhere)
because for security SNMP daemon runs as non-root user (snmp).
Note: A similar patch was rejected previously because of a concern about
the possibility that on some hardware querying the ethtool settings
requires access to the PHY and could slow the machine down. But the
security risk of requiring SNMP daemon (and related services)
to run as root far out weighs the risk of denial-of-service.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net')
| -rw-r--r-- | net/core/ethtool.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/core/ethtool.c b/net/core/ethtool.c index d2c4da5..970eb98 100644 --- a/net/core/ethtool.c +++ b/net/core/ethtool.c @@ -1423,6 +1423,7 @@ int dev_ethtool(struct net *net, struct ifreq *ifr) /* Allow some commands to be done by anyone */ switch (ethcmd) { + case ETHTOOL_GSET: case ETHTOOL_GDRVINFO: case ETHTOOL_GMSGLVL: case ETHTOOL_GCOALESCE: |