diff options
author | Russell King <rmk@dyn-67.arm.linux.org.uk> | 2009-02-24 12:46:31 (GMT) |
---|---|---|
committer | Russell King <rmk+kernel@arm.linux.org.uk> | 2009-03-03 13:08:18 (GMT) |
commit | 4da3782151300237db3abe070f716922889252e0 (patch) | |
tree | 5bfc719384ffecf88ad93b286afe3008f24d281c /scripts | |
parent | 7aec53acc0504ab2abd73a6051e7b72f48545ceb (diff) | |
download | linux-fsl-qoriq-4da3782151300237db3abe070f716922889252e0.tar.xz |
[ARM] omap: clk_set_parent: deny changing parent if clock is enabled
Richard Woodruff writes:
| The historic usage of this has been against single use leaf clocks
| (1st instance of gptimer). When it was used it did:
| clk_get()
| clk_set_parent()
| clk_enable()
|
| This usage was ok for that. Use on a disabled clock is needed.
|
| If there are multiple users on the clock or it is enabled there are
| problems.
|
| The call can still be unfriendly if 2 different drivers are using the
| clock with their own clock get/enable. It might be the function should
| return an error if usecount != 0 to stop surprises. It is all around
| better if the parenting is done when the clock is off.
This is a good reason to ensure that the clock is not enabled when
clk_set_parent() is called.
Acked-by: Richard Woodruff <r-woodruff2@ti.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions