diff options
| author | Axel Lin <axel.lin@gmail.com> | 2010-12-03 09:25:57 (GMT) |
|---|---|---|
| committer | Mark Brown <broonie@opensource.wolfsonmicro.com> | 2010-12-03 12:25:24 (GMT) |
| commit | 4bd3a1f415affa4729856dca7e39c5093a9a954f (patch) | |
| tree | def7331d15cdf125181bbd9d919f966be558b5dd /sound/oss/sb_audio.c | |
| parent | 43fa95caab86fec0af7333bda407dd14f0c2127c (diff) | |
| download | linux-fsl-qoriq-4bd3a1f415affa4729856dca7e39c5093a9a954f.tar.xz | |
ASoC: Fix inconsistent meaning of default case while checking alc5623->id
In alc5623_i2c_probe(),
the default case for checking alc5623->id behaves the same as case 0x23.
However, In alc5623_probe() the default case for checking alc5623->id
becomes to be the same as case 0x21.
This makes the meaning of default case inconsistent.
Since we have checked codec id in alc5623_i2c_probe() by comparing
vid2 with id->driver_data, it is not possible to run into the default case now.
In case we may add more supported devices to alc5623_i2c_table in the future,
this patch changes the default case return -EINVAL to let people know that
they should not run into this case. They should also add a new case accordingly
for the new id.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Arnaud Patard <arnaud.patard@rtp-net.org>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Diffstat (limited to 'sound/oss/sb_audio.c')
0 files changed, 0 insertions, 0 deletions