summaryrefslogtreecommitdiff
path: root/tools/testing
diff options
context:
space:
mode:
authorThomas Petazzoni <thomas.petazzoni@free-electrons.com>2013-01-06 10:10:43 (GMT)
committerJason Cooper <jason@lakedaemon.net>2013-01-06 17:53:25 (GMT)
commitab6e439fd07aba7cadcadb3fb5e11d3758e19679 (patch)
treef123a743e71256d792a28a56e7cc3b8ee63b11d7 /tools/testing
parent41be8dc1a44ee2a0a52bdf2b77273624c40782b6 (diff)
downloadlinux-fsl-qoriq-ab6e439fd07aba7cadcadb3fb5e11d3758e19679.tar.xz
dma: mv_xor: fix error handling of mv_xor_channel_add()
When mv_xor_channel_add() fails for one XOR channel, we jump to the err_channel_add label to clean up all previous channels that had been initialized correctly. Unfortunately, while handling this error condition, we were disposing the IRQ mapping before calling mv_xor_channel_remove() (which does the free_irq()), which is incorrect. Instead, do things properly in the reverse order of the initialization: first remove the XOR channel (so that free_irq() is done), and then dispose the IRQ mapping. This avoids ugly warnings when for some reason one of the XOR channel fails to initialize. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Signed-off-by: Jason Cooper <jason@lakedaemon.net>
Diffstat (limited to 'tools/testing')
0 files changed, 0 insertions, 0 deletions