diff options
Diffstat (limited to 'drivers/staging/line6')
-rw-r--r-- | drivers/staging/line6/capture.c | 4 | ||||
-rw-r--r-- | drivers/staging/line6/driver.c | 2 | ||||
-rw-r--r-- | drivers/staging/line6/pod.c | 8 |
3 files changed, 7 insertions, 7 deletions
diff --git a/drivers/staging/line6/capture.c b/drivers/staging/line6/capture.c index 8393e25..ea2060b 100644 --- a/drivers/staging/line6/capture.c +++ b/drivers/staging/line6/capture.c @@ -26,7 +26,7 @@ */ static int submit_audio_in_urb(struct snd_pcm_substream *substream) { - int index; + unsigned int index; unsigned long flags; struct snd_line6_pcm *line6pcm = snd_pcm_substream_chip(substream); int i, urb_size; @@ -35,7 +35,7 @@ static int submit_audio_in_urb(struct snd_pcm_substream *substream) spin_lock_irqsave(&line6pcm->lock_audio_in, flags); index = find_first_zero_bit(&line6pcm->active_urb_in, LINE6_ISO_BUFFERS); - if (index < 0 || index >= LINE6_ISO_BUFFERS) { + if (index >= LINE6_ISO_BUFFERS) { spin_unlock_irqrestore(&line6pcm->lock_audio_in, flags); dev_err(s2m(substream), "no free URB found\n"); return -EINVAL; diff --git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c index 85a20d0..f188ece 100644 --- a/drivers/staging/line6/driver.c +++ b/drivers/staging/line6/driver.c @@ -682,7 +682,7 @@ static int line6_probe(struct usb_interface *interface, const struct usb_device_ return -ENODEV; /* check vendor and product id */ - for (devtype = sizeof(line6_id_table) / sizeof(line6_id_table[0]) - 1; devtype--;) + for (devtype = ARRAY_SIZE(line6_id_table) - 1; devtype--;) if ((le16_to_cpu(usbdev->descriptor.idVendor) == line6_id_table[devtype].idVendor) && (le16_to_cpu(usbdev->descriptor.idProduct) == line6_id_table[devtype].idProduct)) break; diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c index fa5caa2..4c5b9d5 100644 --- a/drivers/staging/line6/pod.c +++ b/drivers/staging/line6/pod.c @@ -123,7 +123,7 @@ static void pod_mark_batch_all_dirty(struct usb_line6_pod *pod) { int i; - for (i = POD_CONTROL_SIZE; i--;) + for (i = 0; i < POD_CONTROL_SIZE; i++) set_bit(i, pod->param_dirty); } @@ -579,8 +579,8 @@ static ssize_t pod_set_dump(struct device *dev, struct device_attribute *attr, if (count != sizeof(pod->prog_data)) { dev_err(pod->line6.ifcdev, - "data block must be exactly %d bytes\n", - (int)sizeof(pod->prog_data)); + "data block must be exactly %d bytes\n", + sizeof(pod->prog_data)); return -EINVAL; } @@ -692,7 +692,7 @@ static ssize_t pod_set_dump_buf(struct device *dev, if (count != sizeof(pod->prog_data)) { dev_err(pod->line6.ifcdev, "data block must be exactly %d bytes\n", - (int)sizeof(pod->prog_data)); + sizeof(pod->prog_data)); return -EINVAL; } |