diff options
| author | Jingoo Han <jg1.han@samsung.com> | 2012-10-23 12:18:21 (GMT) |
|---|---|---|
| committer | Bryan Wu <cooloney@gmail.com> | 2012-11-26 22:28:44 (GMT) |
| commit | 31c3dc7488f2564fc398d5a416726031f56d6343 (patch) | |
| tree | e67014a35ca9960fb31bd6faf2f3703606eff30f | |
| parent | 507d967bc1d103695440e27f888244e014bcf7be (diff) | |
| download | linux-31c3dc7488f2564fc398d5a416726031f56d6343.tar.xz | |
leds: leds-ns2: use gpio_request_one
Using gpio_request_one can make the code simpler because it can
set the direction and initial value in one shot.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Bryan Wu <cooloney@gmail.com>
| -rw-r--r-- | drivers/leds/leds-ns2.c | 21 |
1 files changed, 7 insertions, 14 deletions
diff --git a/drivers/leds/leds-ns2.c b/drivers/leds/leds-ns2.c index d176ec8..ae8f93b 100644 --- a/drivers/leds/leds-ns2.c +++ b/drivers/leds/leds-ns2.c @@ -191,25 +191,18 @@ create_ns2_led(struct platform_device *pdev, struct ns2_led_data *led_dat, int ret; enum ns2_led_modes mode; - ret = gpio_request(template->cmd, template->name); - if (ret == 0) { - ret = gpio_direction_output(template->cmd, - gpio_get_value(template->cmd)); - if (ret) - gpio_free(template->cmd); - } + ret = gpio_request_one(template->cmd, + GPIOF_DIR_OUT | gpio_get_value(template->cmd), + template->name); if (ret) { dev_err(&pdev->dev, "%s: failed to setup command GPIO\n", template->name); + return ret; } - ret = gpio_request(template->slow, template->name); - if (ret == 0) { - ret = gpio_direction_output(template->slow, - gpio_get_value(template->slow)); - if (ret) - gpio_free(template->slow); - } + ret = gpio_request_one(template->slow, + GPIOF_DIR_OUT | gpio_get_value(template->slow), + template->name); if (ret) { dev_err(&pdev->dev, "%s: failed to setup slow GPIO\n", template->name); |