diff options
| author | Takashi Iwai <tiwai@suse.de> | 2015-05-20 04:49:37 (GMT) |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2015-05-20 04:49:37 (GMT) |
| commit | 48f4b3a2ece560e37232fe9d681cd2ff0f3ff10d (patch) | |
| tree | 7199a70fba793d96ecfbcc1d0084eb8fe43d798c | |
| parent | 976fa9a3ac9223d134cb4e1e3acf0e57160ee924 (diff) | |
| download | linux-48f4b3a2ece560e37232fe9d681cd2ff0f3ff10d.tar.xz | |
ALSA: hda - Reduce verbs by node power-saves
The widget (node) power-saves restore the widget states at each
transition from D3 to D0 on each node. This was added in the commit
[d545a57c5f84:ALSA: hda - Sync node attributes at resume from widget
power saving]. However, the test was rater false-positive; this
wasn't needed for any codecs.
Since the resync may take significant number of additional verbs to be
executed, it's better to reduce it. Let's disable it for now again.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
| -rw-r--r-- | sound/pci/hda/hda_generic.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/sound/pci/hda/hda_generic.c b/sound/pci/hda/hda_generic.c index 788f969..1c86787 100644 --- a/sound/pci/hda/hda_generic.c +++ b/sound/pci/hda/hda_generic.c @@ -844,8 +844,16 @@ static hda_nid_t path_power_update(struct hda_codec *codec, snd_hda_codec_write(codec, nid, 0, AC_VERB_SET_POWER_STATE, state); changed = nid; + /* all known codecs seem to be capable to handl + * widgets state even in D3, so far. + * if any new codecs need to restore the widget + * states after D0 transition, call the function + * below. + */ +#if 0 /* disabled */ if (state == AC_PWRST_D0) snd_hdac_regmap_sync_node(&codec->core, nid); +#endif } } return changed; |