diff options
| author | Ben Hutchings <bhutchings@solarflare.com> | 2013-06-18 16:45:40 (GMT) |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-06-20 05:18:52 (GMT) |
| commit | 776fbcc9cbece10756bdb67b48a0798e6446f16b (patch) | |
| tree | 34edd470f62668234701d4bc6c02990a7c07593c | |
| parent | 3ac19c900cf4a46748d789c49d84a58c37b93841 (diff) | |
| download | linux-776fbcc9cbece10756bdb67b48a0798e6446f16b.tar.xz | |
sfc: Remove write permission from phy_type attribute
Driver probe currently results in:
WARNING: at drivers/base/core.c:576 device_create_file+0x57/0x7e()
Attribute phy_type: write permission without 'store'
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/sfc/efx.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c index 39e4cb3..4a14a94 100644 --- a/drivers/net/ethernet/sfc/efx.c +++ b/drivers/net/ethernet/sfc/efx.c @@ -2139,7 +2139,7 @@ show_phy_type(struct device *dev, struct device_attribute *attr, char *buf) struct efx_nic *efx = pci_get_drvdata(to_pci_dev(dev)); return sprintf(buf, "%d\n", efx->phy_type); } -static DEVICE_ATTR(phy_type, 0644, show_phy_type, NULL); +static DEVICE_ATTR(phy_type, 0444, show_phy_type, NULL); static int efx_register_netdev(struct efx_nic *efx) { |