diff options
| author | Felipe Balbi <balbi@ti.com> | 2012-07-23 06:09:32 (GMT) |
|---|---|---|
| committer | Felipe Balbi <balbi@ti.com> | 2012-08-03 06:28:25 (GMT) |
| commit | 77fa6df82f154535293beb9bc68851f75c2c22cb (patch) | |
| tree | 8e958aba8b60fa8ef9fea7605f1652cc9ba3c2f1 | |
| parent | 4635d3f29864d723a74983339ffc85db212e304b (diff) | |
| download | linux-77fa6df82f154535293beb9bc68851f75c2c22cb.tar.xz | |
usb: dwc3: ep0: ignore XferNotReady(STATUS) when we're not expecting it
Databook doesn't say we should stall if we
get XferNotReady(STATUS) while we're expecting
something else.
Instead of stalling and restarting, tests have
proven that ignoring the event is far more
effective.
This problem has been caught while rewriting
ep0 handling in order we pass Link Layer TD7.6.
Signed-off-by: Felipe Balbi <balbi@ti.com>
| -rw-r--r-- | drivers/usb/dwc3/ep0.c | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/drivers/usb/dwc3/ep0.c b/drivers/usb/dwc3/ep0.c index d4b38c7..39abc58 100644 --- a/drivers/usb/dwc3/ep0.c +++ b/drivers/usb/dwc3/ep0.c @@ -953,19 +953,13 @@ static void dwc3_ep0_xfernotready(struct dwc3 *dwc, break; case DEPEVT_STATUS_CONTROL_STATUS: + if (dwc->ep0_next_event != DWC3_EP0_NRDY_STATUS) + return; + dev_vdbg(dwc->dev, "Control Status\n"); dwc->ep0state = EP0_STATUS_PHASE; - if (dwc->ep0_next_event != DWC3_EP0_NRDY_STATUS) { - dev_vdbg(dwc->dev, "Expected %d got %d\n", - dwc->ep0_next_event, - DWC3_EP0_NRDY_STATUS); - - dwc3_ep0_stall_and_restart(dwc); - return; - } - if (dwc->delayed_status) { WARN_ON_ONCE(event->endpoint_number != 1); dev_vdbg(dwc->dev, "Mass Storage delayed status\n"); |