diff options
| author | Josef Bacik <jbacik@fusionio.com> | 2013-04-20 14:18:27 (GMT) |
|---|---|---|
| committer | Josef Bacik <jbacik@fusionio.com> | 2013-05-06 19:55:03 (GMT) |
| commit | 79fb65a1f6d97febc232e1e4e56019b0c9208541 (patch) | |
| tree | 7f2de2444ea17770e172d5fa91e60859eb4405f6 | |
| parent | 9bb91873e32af6305a1c5239024674e4a5a97e92 (diff) | |
| download | linux-79fb65a1f6d97febc232e1e4e56019b0c9208541.tar.xz | |
Btrfs: don't call readahead hook until we have read the entire eb
Martin Steigerwald reported a BUG_ON() where we were given a bogus bytenr to
map. Turns out he is using > PAGESIZE leafsizes. The readahead stuff is called
every time we do a completion, but we may not have finished reading in all the
pages, so the bytenr we read off the node could be completely bogus. Fix this
by only calling the readahead hook once all pages have been read in. Thanks,
Reported-by: Martin Steigerwald <Martin@lichtvoll.de>
Signed-off-by: Josef Bacik <jbacik@fusionio.com>
| -rw-r--r-- | fs/btrfs/disk-io.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index aab7d89..bb6cdbd 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -636,10 +636,9 @@ static int btree_readpage_end_io_hook(struct page *page, u64 start, u64 end, if (!ret) set_extent_buffer_uptodate(eb); err: - if (test_bit(EXTENT_BUFFER_READAHEAD, &eb->bflags)) { - clear_bit(EXTENT_BUFFER_READAHEAD, &eb->bflags); + if (reads_done && + test_and_clear_bit(EXTENT_BUFFER_READAHEAD, &eb->bflags)) btree_readahead_hook(root, eb, eb->start, ret); - } if (ret) { /* |